Fix not working with Gemini models #2021
Conversation
|
|
|
@Dev-Khant Gemini will not be available for now, I hope you consider and merge it soon if possible. |
|
@spike-spiegel-21 @Dev-Khant While working on the library I resolved some related bugs so that Gemini could work with |
| elif self.llm_provider == "gemini": | ||
| # The `noop` function n should be removed because it is unnecessary | ||
| # and causes the error: "should be non-empty for OBJECT type" | ||
| _tools = [UPDATE_MEMORY_TOOL_GRAPH, ADD_MEMORY_TOOL_GRAPH] |
There was a problem hiding this comment.
Trying to add a noop function here seems unnecessary, and will return an error that the value in the object cannot be empty (from the Gemini related library).
There was a problem hiding this comment.
Hey @lh0x00 we want to keep the noop operation as it is present for all the llms, so is there a workaround for this? Because removing this would be inconsistent.
|
@Dev-Khant I updated to resolve test fails. |
|
Is this PR still under consideration my friends? @Dev-Khant @spike-spiegel-21 |
Description
This PR's did the following:
geminiin LLM's provider check.noop, updated function to parse function calls returning Gemini (based on their source code/docs).All tested by my app working properly again.
Type of change
Please delete options that are not relevant.