store: add StatusSuspended to the Instance Status

Signed-off-by: Norio Nomura <[email protected]>
lima-vm · Nov 16, 2024 · 8b4dc0f · 8b4dc0f
1 parent 79c0277
commit 8b4dc0f
Show file tree

Hide file tree

Showing 8 changed files with 25 additions and 2 deletions.
diff --git a/cmd/limactl/copy.go b/cmd/limactl/copy.go
@@ -77,6 +77,8 @@ func copyAction(cmd *cobra.Command, args []string) error {
 			}
 			if inst.Status == store.StatusStopped {
 				return fmt.Errorf("instance %q is stopped, run `limactl start %s` to start the instance", instName, instName)
+			} else if inst.Status == store.StatusSuspended {
+				return fmt.Errorf("instance %q is suspended, run `limactl start %s` to resume the instance", instName, instName)
 			}
 			if legacySSH {
 				scpFlags = append(scpFlags, "-P", fmt.Sprintf("%d", inst.SSHLocalPort))

diff --git a/cmd/limactl/disk.go b/cmd/limactl/disk.go
@@ -331,6 +331,9 @@ func diskUnlockAction(_ *cobra.Command, args []string) error {
 			if inst.Status == store.StatusRunning {
 				logrus.Warnf("Cannot unlock disk %q used by running instance %q", diskName, disk.Instance)
 				continue
+			} else if inst.Status == store.StatusSuspended {
+				logrus.Warnf("Cannot unlock disk %q used by suspended instance %q", diskName, disk.Instance)
+				continue
 			}
 		}
 		if err := disk.Unlock(); err != nil {
@@ -387,6 +390,8 @@ func diskResizeAction(cmd *cobra.Command, args []string) error {
 		if err == nil {
 			if inst.Status == store.StatusRunning {
 				return fmt.Errorf("cannot resize disk %q used by running instance %q. Please stop the VM instance", diskName, disk.Instance)
+			} else if inst.Status == store.StatusSuspended {
+				return fmt.Errorf("cannot resize disk %q used by suspended instance %q. Please resume and stop the VM instance", diskName, disk.Instance)
 			}
 		}
 	}

diff --git a/cmd/limactl/edit.go b/cmd/limactl/edit.go
@@ -68,6 +68,8 @@ func editAction(cmd *cobra.Command, args []string) error {
 
 		if inst.Status == store.StatusRunning {
 			return errors.New("cannot edit a running instance")
+		} else if inst.Status == store.StatusSuspended {
+			return errors.New("cannot edit a suspended instance")
 		}
 		filePath = filepath.Join(inst.Dir, filenames.LimaYAML)
 	}

diff --git a/cmd/limactl/shell.go b/cmd/limactl/shell.go
@@ -77,6 +77,8 @@ func shellAction(cmd *cobra.Command, args []string) error {
 	}
 	if inst.Status == store.StatusStopped {
 		return fmt.Errorf("instance %q is stopped, run `limactl start %s` to start the instance", instName, instName)
+	} else if inst.Status == store.StatusSuspended {
+		return fmt.Errorf("instance %q is suspended, run `limactl start %s` to resume the instance", instName, instName)
 	}
 
 	// When workDir is explicitly set, the shell MUST have workDir as the cwd, or exit with an error.

diff --git a/cmd/limactl/start.go b/cmd/limactl/start.go
@@ -490,7 +490,7 @@ func startAction(cmd *cobra.Command, args []string) error {
 			inst.Name, instance.LimactlShellCmd(inst.Name))
 		// Not an error
 		return nil
-	case store.StatusStopped:
+	case store.StatusStopped, store.StatusSuspended:
 		// NOP
 	default:
 		logrus.Warnf("expected status %q, got %q", store.StatusStopped, inst.Status)

diff --git a/cmd/limactl/tunnel.go b/cmd/limactl/tunnel.go
@@ -70,6 +70,8 @@ func tunnelAction(cmd *cobra.Command, args []string) error {
 	}
 	if inst.Status == store.StatusStopped {
 		return fmt.Errorf("instance %q is stopped, run `limactl start %s` to start the instance", instName, instName)
+	} else if inst.Status == store.StatusSuspended {
+		return fmt.Errorf("instance %q is suspended, run `limactl start %s` to resume the instance", instName, instName)
 	}
 
 	if port == 0 {

diff --git a/pkg/instance/stop.go b/pkg/instance/stop.go
@@ -17,6 +17,7 @@ import (
 )
 
 func StopGracefully(inst *store.Instance) error {
+	// TODO: support store.StatusSuspended
 	if inst.Status != store.StatusRunning {
 		return fmt.Errorf("expected status %q, got %q (maybe use `limactl stop -f`?)", store.StatusRunning, inst.Status)
 	}

diff --git a/pkg/store/instance.go b/pkg/store/instance.go
@@ -36,6 +36,7 @@ const (
 	StatusBroken        Status = "Broken"
 	StatusStopped       Status = "Stopped"
 	StatusRunning       Status = "Running"
+	StatusSuspended     Status = "Suspended"
 )
 
 type Instance struct {
@@ -198,7 +199,15 @@ func inspectStatusWithPIDFiles(instDir string, inst *Instance, y *limayaml.LimaY
 		case inst.HostAgentPID > 0 && inst.DriverPID > 0:
 			inst.Status = StatusRunning
 		case inst.HostAgentPID == 0 && inst.DriverPID == 0:
-			inst.Status = StatusStopped
+			_, err = os.Stat(filepath.Join(instDir, filenames.VzMachineState))
+			if err == nil {
+				inst.Status = StatusSuspended
+			} else if errors.Is(err, os.ErrNotExist) {
+				inst.Status = StatusStopped
+			} else {
+				inst.Errors = append(inst.Errors, err)
+				inst.Status = StatusBroken
+			}
 		case inst.HostAgentPID > 0 && inst.DriverPID == 0:
 			inst.Errors = append(inst.Errors, errors.New("host agent is running but driver is not"))
 			inst.Status = StatusBroken