feat: add onTappedSquare to Chessboard widget, add squareHighlights field #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll need this if we want to switch the coordinate trainer in the app from `ChessboardEditor` to `Chessboard` in order to fix lichess-org/mobile#1017
tom-anders
changed the title
veloce
reviewed
Dec 27, 2024
| @@ -549,6 +570,8 @@ class _BoardState extends State<Chessboard> { | |||
| final square = widget.offsetSquare(details.localPosition); | |||
| if (square == null) return; | |||
|
|
|||
| widget.onTappedSquare?.call(square); | |||
There was a problem hiding this comment.
Calling this onTapped is misleading since the callback is executed on pointer down.
There was a problem hiding this comment.
Hmm yeah I wasn't sure whether to put this into pointer down or up - Now that I think about it again, if we call it onTapped it should probably be in pointer up instead? And we should only invoke the callback if the pointer up happened on the same square as the previous pointer down event
There was a problem hiding this comment.
Or should we keep it in _onPointerDown and change the callback's name instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll need this if we want to switch the coordinate trainer in the app
from
ChessboardEditortoChessboardin order to fix lichess-org/mobile#1017