-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow creating matrices based on hash tables #3983
base: devel
Are you sure you want to change the base?
Conversation
Those look like real failures - somehow in a bunch of use cases we're now trying to zero a matrix before it's initialized? |
Yea, I'll get back to this particular PR soon |
17dc9e1
to
3b318be
Compare
This reverts commit 510cbbb.
3b318be
to
d7b4e6e
Compare
Job Coverage, step Generate coverage on b964294 wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
this is ready for review |
I take it there's no way via PETSc to get around the need for Other than that this is looking good now. |
The thing is that there is no "hash table" matrix in PETSc. There is just a "hash table until you call |
As the new example test is currently written, we will need https://gitlab.com/petsc/petsc/-/merge_requests/8063 to fix the failure. I'll probably just skip resetting the preallocation for the "non-hash-table" matrix in the mean time |
I have no idea how this broke MetaPhysicL |
8d08543
to
a7df39b
Compare
4a8a5e3
to
b964294
Compare
Huzzah! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ready to go to me, but it's a big enough changeset that I'd say let's let @jwpeterson also have a chance to agree or object before merging.
This is only supported by the PETSc backend