cli: Remove type restrictions #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Green-Sky
reviewed
Nov 28, 2024
examples/cli/main.cpp
Outdated
| std::string name(trait->type_name); | ||
| if (i) | ||
| valid_types += ", "; | ||
| valid_types += name; |
There was a problem hiding this comment.
the type enum is non contiguous, so we check for something here, maybe empty name?
|
I'm really impressed by "iq4_nl" type. It runs faster than q4_k on my machine, and the quality seems on par with q5_1 (for sd3.5 large models at least). |
|
Thank you for your contribution. |
stduhpf
added a commit
to stduhpf/stable-diffusion.cpp
that referenced
this pull request
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to use any GGML type instead of only legacy quants and the small selection of k-quants.
Some quant types are not compatible with some backends, but having more options is good I think.
(also, it solves #431)