update ggml to 2024-10-03 #473
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Green-Sky
commented
Nov 20, 2024
stable-diffusion.cpp
Outdated
| @@ -47,6 +48,8 @@ const char* sampling_methods_str[] = { | |||
| "LCM", | |||
| }; | |||
|
|
|||
| static_assert((int)SD_TYPE_COUNT == (int)GGML_TYPE_COUNT); | |||
There was a problem hiding this comment.
sadly a c++17 feature...
Green-Sky
force-pushed
the
update_ggml_24_10_03
branch
3 times, most recently
from
c9c9810 to
578ae37
Compare
|
Looks like newer ggml failes to compile on older rocm, because of a compiler bug. We need to solve this by updating the hip sdk (like llama.cpp). Will ignore for now. |
Green-Sky
force-pushed
the
update_ggml_24_10_03
branch
from
578ae37 to
bfaa294
Compare
|
Ok, changes are upsteam now |
|
Including the failing rocm build :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.