-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(env): docker compose variable interpolation issue for COMPOSE_PRO… #12093
fix(env): docker compose variable interpolation issue for COMPOSE_PRO… #12093
Conversation
You should modify this file instead of modify the |
Correct me if I'm wrong @crazywoola but it seems the sequence of generation goes like this (as per Reads There is nowhere in the |
It seems that COMPOSE_PROFILES shouldn’t appear in the docker-compose.yaml file. You should modify the generate-docker-compose script to ignore this key. |
Okay. I'll try and ignore that specific key. Will commit soon-ish due to the fact it's Xmas season 😄 |
@laipz8200 Hi, can you please have another look? I believe it's as straightforward as it gets in terms of ignoring that key as per your advice. I have regenerated the Sorry for the delay due to holidays hhh. |
Looks good to me. Now, the |
All done, mate. Please help to approve and merge at will 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your contribution!
Updated files
generate-docker-compose
docker-compose.yml
Summary
Added condition to ignore the environment variable
COMPOSE_PROFILES
. Otherwise, it will fail upon runningdocker compose up -d
with the current interpolation setup.Fixes #12081
Screenshots
Checklist
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods