Implemented keybinder_set_avoid_cooking_shift_accelerators to fix Shift problems #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a failing make distcheck
Resources allocated by XkbGetMap() should be freed by XkbFreeKeyboard. Otherwise I get the following leaked memory report from Valgrind: ==14972== 1,920 bytes in 48 blocks are definitely lost in loss record 1,598 of 1,626 ==14972== at 0x402C118: calloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so) ==14972== by 0x5064EA8: XkbGetMap (in /usr/lib/i386-linux-gnu/libX11.so.6.3.0) ==14972== by 0x428019D: grab_ungrab (bind.c:203) ==14972== by 0x4280320: do_grab_key (bind.c:326) ==14972== by 0x4280721: keybinder_bind_full (bind.c:574) ==14972== by 0x4280791: keybinder_bind (bind.c:539) ==14972== by 0x8049220: xvd_keys_init (xvd_keys.c:141) ==14972== by 0x8048F84: main (main.c:126)
This fixes two following warnings: bind.c:496: Warning: Keybinder: GObject-Introspection specific GTK-Doc tag "Rename to" has been deprecated, please use annotations on the identifier instead: * Rename to: keybinder_bind ^ bind.c:570: Warning: Keybinder: GObject-Introspection specific GTK-Doc tag "Rename to" has been deprecated, please use annotations on the identifier instead: * Rename to: keybinder_unbind ^ Signed-off-by: Dmitry Eremin-Solenikov <[email protected]>
Fix the following warning: note: pygtk-codegen-2.0 is deprecated, use pygobject-codegen-2.0 instead note: I will now try to invoke pygobject-codegen-2.0 in the same directory Signed-off-by: Dmitry Eremin-Solenikov <[email protected]>
Fix the following issue reported by automake: libkeybinder/Makefile.am:1: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') lua-keybinder/Makefile.am:1: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') python-keybinder/Makefile.am:1: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') Signed-off-by: Dmitry Eremin-Solenikov <[email protected]>
… a similar behavior as keybinder-3.0 keybinder_set_use_cooked_accelerators). Enabled by default to make Shift modifiers work Included Python bindings to toggle this function
|
Hi, thank you, but old libkeybinder (not keybinder-3.0) is effectively discontinued, unless someone wants to maintain it. |
bluss
force-pushed
the
master
branch
2 times, most recently
from
845eeb1 to
1c3680e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements keybinder_set_avoid_cooking_shift_accelerators for the master branch using GTK 2.0 (which has a similar behavior as keybinder-3.0 keybinder_set_use_cooked_accelerators). Enabled by default to make Shift modifiers work.
Included Python bindings to toggle this function.