Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added build and push functionality for multi-arch #615

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

modassarrana89
Copy link
Contributor

@modassarrana89 modassarrana89 commented Dec 6, 2024

Description

  1. Multi-arch changes have been done in build-and-push-image.yml. Same will be replicated in other build & publish github workflow (Ex: build-and-push-ui-image.yml , csi-build-and-push-image.yml)
  2. Removed Push functionality from the script as that will be handle by image/buildx

Note This will increase time. Before it used to take around 5 min for this workflow . Now with the changes , it will take around 35 min. Since we are invoking 3 time buid & publish for different tags , so thats why it took this much time.

How Has This Been Tested?

  1. Tested Github workflow by pushing it to local Repository [https://github.com/modassarrana89/model-registry/actions/runs/12194706066]
Screenshot 2024-12-06 at 18 20 23

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tarilabs for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@modassarrana89
Copy link
Contributor Author

@tarilabs I have added the workflow for multi-arch image . Currently its a draft version , but don't know how to add label (do-not-merge/work-in-progress). Please review & add labels if possible as well

@tarilabs tarilabs marked this pull request as draft December 6, 2024 20:17
@tarilabs
Copy link
Member

tarilabs commented Dec 6, 2024

Added Draft status as requested.

@modassarrana89
Copy link
Contributor Author

@tarilabs @andreyvelich please review the changes & do let me know

@tarilabs
Copy link
Member

@tarilabs @andreyvelich please review the changes & do let me know

Hi, thanks for reaching out.
As mentioned in DM, same question, can you clarify what is the desired status of this PR, please?

In the #615 (comment) you asked for this to be placed as Draft, which I acted.

Do you want to move this into Ready status, for review?

@modassarrana89
Copy link
Contributor Author

@tarilabs @andreyvelich please review the changes & do let me know

Hi, thanks for reaching out. As mentioned in DM, same question, can you clarify what is the desired status of this PR, please?

In the #615 (comment) you asked for this to be placed as Draft, which I acted.

Do you want to move this into Ready status, for review?

Yes , Please move to Review State.

@tarilabs tarilabs changed the title Added build and push functionality for multi-arch [ DO NOT MERGE / Work In progress ] Added build and push functionality for multi-arch Dec 12, 2024
@tarilabs tarilabs marked this pull request as ready for review December 12, 2024 10:28
@google-oss-prow google-oss-prow bot requested a review from rareddy December 12, 2024 10:28
@tarilabs
Copy link
Member

Marking as ready for review per author's request.
cc @dhirajsb @Al-Pragliola

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants