feat: add database exploring for mongodb #268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristijanhusak
requested changes
Jan 3, 2025
| @@ -208,6 +208,16 @@ let s:bigquery = { | |||
| \ 'requires_stdin': v:true, | |||
| \ } | |||
|
|
|||
| let s:mongodb_dbs_query = '"\n" + db.adminCommand("listDatabases").databases.map(x => x.name).join("\n")' | |||
There was a problem hiding this comment.
We need to consider the case where the database name is defined in the url, for example mongodb://localhost:27017/my_test_db.
In that situation, we should just show table names.
We already do similar thing for mysql/mariadb here. We can convert that to a hash map and consider mongodb and mongodb+srv as part of that.
I added this myself to see how it looks, and noticed that table names in drawer got db. prepended, like db.users. We can probably solve that in the schemes_tables_query somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104