Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --package flag to release management commands #18

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Add --package flag to release management commands #18

merged 1 commit into from
Oct 4, 2024

Conversation

daveads
Copy link
Contributor

@daveads daveads commented Oct 4, 2024 •
edited
Loading

This commit introduces the --package flag to several release management commands to support multi-package products. The affected commands are:

  • publish
  • yank
  • tag
  • untag
  • del

/claim #16

@algora-pbc algora-pbc bot mentioned this pull request Oct 4, 2024
Closed
@daveads
Copy link
Contributor Author

daveads commented Oct 4, 2024

@ezekg review..

ezekg
ezekg approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@ezekg ezekg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. But I'd like you to cleanup some stylistic issues i.r.t. newlines before merging.

ty

cmd/publish.go Outdated Show resolved Hide resolved
cmd/publish.go Outdated Show resolved Hide resolved
cmd/tag.go Outdated Show resolved Hide resolved
cmd/tag.go Outdated Show resolved Hide resolved
cmd/tag.go Outdated Show resolved Hide resolved
cmd/untag.go Outdated Show resolved Hide resolved
cmd/untag.go Outdated Show resolved Hide resolved
cmd/yank.go Outdated Show resolved Hide resolved
cmd/yank.go Outdated Show resolved Hide resolved
cmd/yank.go Outdated Show resolved Hide resolved
ezekg
ezekg reviewed Oct 4, 2024
View reviewed changes
cmd/publish.go Outdated Show resolved Hide resolved
ezekg
ezekg reviewed Oct 4, 2024
View reviewed changes
cmd/tag.go Outdated Show resolved Hide resolved
ezekg
ezekg reviewed Oct 4, 2024
View reviewed changes
cmd/untag.go Show resolved Hide resolved
ezekg
ezekg reviewed Oct 4, 2024
View reviewed changes
cmd/untag.go Outdated Show resolved Hide resolved
ezekg
ezekg reviewed Oct 4, 2024
View reviewed changes
cmd/yank.go Show resolved Hide resolved
ezekg
ezekg reviewed Oct 4, 2024
View reviewed changes
cmd/yank.go Outdated Show resolved Hide resolved
ezekg
ezekg requested changes Oct 4, 2024
View reviewed changes
Copy link
Member

@ezekg ezekg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed you're missing the del command.

@daveads
Copy link
Contributor Author

daveads commented Oct 4, 2024

Just noticed you're missing the del command.

alright adding that.

@daveads
Copy link
Contributor Author

daveads commented Oct 4, 2024

@ezekg done

@daveads
Copy link
Contributor Author

daveads commented Oct 4, 2024

@ezekg squashed commit.

@ezekg ezekg merged commit eee45ca into keygen-sh:master Oct 4, 2024
2 checks passed
@ezekg
Copy link
Member

ezekg commented Oct 4, 2024

/approve

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Oct 4, 2024

@ezekg: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezekg ezekg ezekg approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daveads @ezekg