Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to issue #20616 #20683

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rujutajoshi232
Copy link

Fixes #20616

Copy link

google-cla bot commented Dec 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.19%. Comparing base (3dd958b) to head (0f3a19d).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/ops/numpy.py 0.00% 2 Missing and 2 partials ⚠️

❗ There is a different number of reports uploaded between BASE (3dd958b) and HEAD (0f3a19d). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (3dd958b) HEAD (0f3a19d)
keras 5 3
keras-torch 1 0
keras-tensorflow 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #20683       +/-   ##
===========================================
- Coverage   81.97%   70.19%   -11.79%     
===========================================
  Files         544      544               
  Lines       50751    50777       +26     
  Branches     7851     7856        +5     
===========================================
- Hits        41604    35643     -5961     
- Misses       7252    13283     +6031     
+ Partials     1895     1851       -44     
Flag Coverage Δ
keras 70.16% <0.00%> (-11.65%) ⬇️
keras-jax 63.93% <0.00%> (-0.02%) ⬇️
keras-numpy 58.86% <0.00%> (-0.01%) ⬇️
keras-openvino 29.92% <0.00%> (-0.02%) ⬇️
keras-tensorflow ?
keras-torch ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this seems fine.

@@ -4718,6 +4718,8 @@ def test_eye(self):
# Test k < 0 and M < N and M - k > N
self.assertAllClose(knp.Eye(k=-2)(4, 3), np.eye(4, 3, k=-2))



Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove added blank lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What is correct behavior of keras.ops.eye?
4 participants