-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to issue #20616 #20683
base: master
Are you sure you want to change the base?
Fix to issue #20616 #20683
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20683 +/- ##
===========================================
- Coverage 81.97% 70.19% -11.79%
===========================================
Files 544 544
Lines 50751 50777 +26
Branches 7851 7856 +5
===========================================
- Hits 41604 35643 -5961
- Misses 7252 13283 +6031
+ Partials 1895 1851 -44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, this seems fine.
keras/src/ops/numpy_test.py
Outdated
@@ -4718,6 +4718,8 @@ def test_eye(self): | |||
# Test k < 0 and M < N and M - k > N | |||
self.assertAllClose(knp.Eye(k=-2)(4, 3), np.eye(4, 3, k=-2)) | |||
|
|||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove added blank lines
Fixes #20616