New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX TypeError: normal_() got an unexpected keyword argument 'generator' #723 #791

Open

earlytobed wants to merge 1 commit into karpathy:master from earlytobed:fix723

+3 −2

earlytobed commented Dec 24, 2024

This PR fixes #723, older PyTorch versions (pre-2.2, roughly, 7fc2929) don’t support arg generator, leading to the error:

Traceback (most recent call last):
    ...
    File "~/llm.c/train_gpt2.py", line 160, in _init_weights
    torch.nn.init.normal_(module.weight, mean=0.0, std=0.02, generator=self.init_rng)
TypeError: normal_() got an unexpected keyword argument 'generator'

after commit 86682af : torch.nn.init.normal_ called with generator, file: train_gpt2.py line146, line150

This PR replaces the torch.nn.init.normal_ with Tensor.normal_, ensuring compatibility with older PyTorch releases.


          FIX TypeError: normal_() got an unexpected keyword argument 'generator'

ab40bdf

karpathy#723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet