-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade using sass-migrator division **/*.scss #705
base: master
Are you sure you want to change the base?
Conversation
Thank you for proposing this change, @BillRaymond. Unfortunately, this is not an acceptable proposal even for a project currently open to breaking changes. If I am not mistaken, Technically, the deprecation can be ignored in this case because it is serving as a "separator" which is future-compatible. For your own use, you have a couple of options to workaround this situation:
|
Thank you for that, @ashmaroli. I think the issue here is when I was installing Ruby (with rbenv) and then created my Gemfile, I added |
No @BillRaymond. gem "jekyll-sass-converter", "< 3.0" In the absence of a proper version directive, Bundler will resolve to the latest version. |
Thank you for the update on this, @ashmaroli. This topic may morph into a different request (see below), but I will mention it here for your review. I am creating a base Docker Ubuntu image that I can use for all my projects. I create the image using the following steps:
I am using rbenv instead of using apt to install If you want to see the whole image that contains other dependencies I like to have, you can see the Dockerfile here. When I create a new container from that image, I go to the repo where I want to use the Docker file and type:
That action, of course, creates the new Jekyll site, but it does not add the dependency you recommend, which is I guess this leaves me to ponder two questions:
FYI, if you need documentation updates, I am happy to help with that. |
There is no need of a period after
That is expected because
No.
I guess you can add this to the "Troubleshooting" page under
Unfortunately, that is not for me to decide. I suggest you open a pull request at the Finally, regarding the dependencies in your Dockerfile, I doubt |
Hi @ashmaroli,
This is just a matter of process I think. I always create a GitHub repo that represents a Jekyll site. I enable the readme option and include the Jekyll
Okay, I understand this process and your reasoning. The reason I suggested updating the Jekyll code to include
Okay, thank you. Once I get a free moment I will propose the change.
Okay, thank you. Once I get a free moment I will propose the change.
Okay, thank you. I will try that. I think my dependencies started stringing together after reading far too many articles on setting up Ubuntu and Ruby on a Docker image that uses multi-arch :-). I will try removing Bison to see if there are any issues on ARM64 or AMD64. I appreciate all the thoughtful replies! |
Hello @BillRaymond, But as a token of respect towards your role in Jekyll community, I propose that you submit a new pull request that replaces the CSS Thank you. |
SASS is deprecating the ability to use a
/
(slash) for division. See the documentation here.Per the documentation, use Automatic Migration with the following code:
I ran this code in the
_sass
folder. One line was added, and one line was modified. DART SASS warnings no longer appear.