feat: add influxdb3_clap_blocks crate with runtime config #25665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new workspace crate `influxdb3_clap_blocks` which will be a starting point for adding InfluxDB 3 OSS/Pro specific CLI configuration that no longer references IOx, and allows for us to trim out unneeded configurations for the monolithic InfluxDB 3. Other than changing references from IOX to INFLUXDB3, this makes one important change: it enables IO on the DataFusion runtime. This, for now, is an experimental change to see if we can relieve some concurrency issues that we have been experiencing.
hiltontj
force-pushed
the
hiltontj/rt-clap
branch
from
5a7f115 to
5a5711f
Compare
pauldix
approved these changes
Dec 16, 2024
|
Waiting for CI again, as 8cd8475 should fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new workspace crate
influxdb3_clap_blockswhich will be a starting point for adding InfluxDB 3 OSS/Pro specific CLI configuration that no longer references IOx, and allows for us to trim out unneeded configurations for the monolithic InfluxDB 3.To start, in this PR, this ports over the code from the
clap_blockstokio.rsmodule from core/IOx.Other than changing references from
IOXtoINFLUXDB3, this makes one important change: it enables IO on the DataFusion runtime. This, at least for now, is an experimental change to see if we can relieve some concurrency issues that we have been experiencing.This leverages the configurable IO runtime from the main
influxdb3process.Closes #25664