Refactor benchmark output handling and add JSON/HTML support #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubcio
force-pushed
the
bench-use-json
branch
2 times, most recently
from
b8c7f61 to
a7677e3
Compare
Pull Request Test Coverage Report for Build 12603924821Details
💛 - Coveralls |
hubcio
changed the title
hubcio
force-pushed
the
bench-use-json
branch
3 times, most recently
from
b8327e5 to
67198ea
Compare
This commit refactors the benchmark output handling by replacing CSV and TOML file generation with JSON and HTML outputs. The `output_directory` argument is replaced with `output`, and the results are now serialized into a JSON file. Additionally, HTML plots are generated using the `charming` library, providing a visual representation of throughput and latency over time. - Removed CSV and TOML dependencies and related code. - Added `charming` and `serde_json` dependencies for JSON and HTML output. - Updated scripts to reflect changes in output handling. - Improved directory handling in performance scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the benchmark output handling by replacing CSV and TOML
file generation with JSON and HTML outputs. The
output_directoryargument isreplaced with
output, and the results are now serialized into a JSON file.Additionally, HTML plots are generated using the
charminglibrary, providinga visual representation of throughput and latency over time.
charmingandserde_jsondependencies for JSON and HTML output.