Enable VolumetricFlowRate for LinearFV #29586
Conversation
|
Job Precheck, step Clang format on cfc893d wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
grmnptr
force-pushed
the
rcrestruct-29582
branch
from
cfc893d to
7b0aac7
Compare
|
Job Documentation, step Docs: sync website on 135d543 wanted to post the following: View the site here This comment will be updated on new commits. |
modules/navier_stokes/test/tests/postprocessors/flow_rates/gold/conservation_LinearFV_out.csv
Outdated
Show resolved
Hide resolved
modules/navier_stokes/src/userobjects/RhieChowFaceFluxProvider.C
Outdated
Show resolved
Hide resolved
| @@ -142,11 +140,12 @@ RhieChowInterpolatorBase::RhieChowInterpolatorBase(const InputParameters & param | |||
| _velocity_interp_method = Moose::FV::InterpMethod::RhieChow; | |||
| } | |||
|
|
|||
| bool | |||
| RhieChowInterpolatorBase::hasFaceSide(const FaceInfo & fi, const bool fi_elem_side) const | |||
| Real | |||
There was a problem hiding this comment.
should you have an AD version of this?
I would be worried someone uses this inadvertently losing derivatives
| RhieChowFaceFluxProvider(const InputParameters & params); | ||
|
|
||
| /** | ||
| * Retrieve the volumetric face flux, will not include derivatives |
There was a problem hiding this comment.
should we have a version of this that includes derivatives?
then the Real value is simply taking the raw value
There was a problem hiding this comment.
(this is the same comment as before)
There was a problem hiding this comment.
not sure we can actually. they would only differ in the return type. and C++ does not like that
There was a problem hiding this comment.
Yeah we can add it with a different name. Right now this is only used in the postprocessor which requires Real.
There was a problem hiding this comment.
I am not going to add it considering that this is used by one thing at this point and the doco states that no AD information is included. I don't want to add a getVolumetricFaceFluxAD function just with no use cases.
|
This new assert is being hit by accident (so it needs a small fix up) but otherwise this is good to go! This will be great for getting more linear FV out there |
Closes #29582