Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add menu_height method to PickList and ComboBox widgets. #2699

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add menu_height method to PickList and ComboBox widgets. #2699

wants to merge 2 commits into from

Conversation

GyulyVGC
Copy link
Contributor

Add menu_height method to PickList and ComboBox widgets.

This is particularly useful to reduce the menu height in presence of a long list of options.

Before

After

@GyulyVGC GyulyVGC mentioned this pull request Dec 17, 2024
Open
@emkkla
Copy link

emkkla commented Dec 24, 2024

Shouldn't we call it menu_length instead of height ?

@GyulyVGC
Copy link
Contributor Author

Shouldn't we call it menu_length instead of height ?

I don't think so... iced always refers to vertical lengths as "height" and to horizontal lengths as "width".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GyulyVGC @emkkla