add StripNormalizer #133
Merged
add StripNormalizer #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzbac
commented
Sep 30, 2024
| @@ -1,6 +1,6 @@ | |||
| // | |||
| // Normalizer.swift | |||
| // | |||
There was a problem hiding this comment.
I'm not sure if there is any formatter I should use, but I noticed the current codebase seems to have the inconsistent format.
There was a problem hiding this comment.
There's not. We'll get there eventually. For now, removing trailing spaces like these is totally fine (thank you!), but I'd rather not reformat existing blocks of code until we agree on a style.
pcuenca
reviewed
Oct 2, 2024
| @@ -1,6 +1,6 @@ | |||
| // | |||
| // Normalizer.swift | |||
| // | |||
There was a problem hiding this comment.
There's not. We'll get there eventually. For now, removing trailing spaces like these is totally fine (thank you!), but I'd rather not reformat existing blocks of code until we agree on a style.
| case .Precompiled : return PrecompiledNormalizer(config: config) | ||
| case .StripAccents : return StripAccentsNormalizer(config: config) | ||
| default : fatalError("Unsupported Normalizer type: \(typeName)") | ||
| case .Prepend: return PrependNormalizer(config: config) |
There was a problem hiding this comment.
these spaces are fine to remove too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try to resolve #127