-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stable diffusion controlnet support #813
Open
TianmengChen
wants to merge
15
commits into
huggingface:main
Choose a base branch
from
TianmengChen:stable-diffusion-controlnet-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Stable diffusion controlnet support #813
TianmengChen
wants to merge
15
commits into
huggingface:main
from
TianmengChen:stable-diffusion-controlnet-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please use Lines 23 to 33 in 439d61f
|
…wd.imputs and model.inputs
sammysun0711
suggested changes
Jul 15, 2024
Comment on lines
+1225
to
+1234
# This attribute is needed to keep one reference on the temporary directory, since garbage collecting | ||
# would end-up removing the directory containing the underlying OpenVINO model | ||
self._model_save_dir_tempdirectory_instance = None | ||
if isinstance(model_save_dir, TemporaryDirectory): | ||
self._model_save_dir_tempdirectory_instance = model_save_dir | ||
self._model_save_dir = Path(model_save_dir.name) | ||
elif isinstance(model_save_dir, str): | ||
self._model_save_dir = Path(model_save_dir) | ||
else: | ||
self._model_save_dir = model_save_dir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply same fix for controlnet in export_controlnet(): #749
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stable diffusion controlnet support depends on huggingface/optimum#1950 this PR