Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core attention #168

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Core attention #168

wants to merge 2 commits into from

Conversation

zzhhjjj
Copy link
Collaborator

@zzhhjjj zzhhjjj commented May 13, 2024

replace flash_attn_varlen_func with flash_attn_func as

  1. We are not using cu_seqlens_q or cu_seqlens_k.
  2. ~2% increase in training speed. Tested with 7b params model, from 358 GFLOPS to 367 GFLOPS

@TJ-Solergibert TJ-Solergibert mentioned this pull request May 20, 2024
Open
9 tasks
@TJ-Solergibert TJ-Solergibert mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zzhhjjj