-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homogeneize generation params #428
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
…n the models to use other attributes later
071d502
to
286668f
Compare
Interestingly, using an explicit generation config seems to mess up this quite a lot |
…ams set by default which slow down generations
…ammatically if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I only reviewed it partially. Some comments below.
…ia the generationparams instead
Co-authored-by: Albert Villanova del Moral <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to have a coherent config, few nits and good to go
Co-authored-by: Albert Villanova del Moral <[email protected]> Co-authored-by: Nathan Habib <[email protected]>
Co-authored-by: Nathan Habib <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ggod ! seems to work, only a few questions :)
This PR does 3 things:
I would put
system_prompt
,fewshot_seeds
, anduse_chat_template
in the GenerationParameters too since they are generation parameters logically, but it can be another PRCloses #16