Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update secret scanning #1354

Merged
merged 4 commits into from
Aug 30, 2024
Merged

feat: update secret scanning #1354

merged 4 commits into from
Aug 30, 2024

Conversation

McPatate
Copy link
Member

Updating the docs to follow our changes to the secret detection system.

https://github.com/huggingface-internal/moon-landing/pull/10615

@McPatate McPatate requested review from julien-c and mishig25 July 29, 2024 13:11
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

docs/hub/security-secrets.md Outdated Show resolved Hide resolved
docs/hub/security-secrets.md Outdated Show resolved Hide resolved
docs/hub/security-secrets.md Outdated Show resolved Hide resolved
@julien-c
Copy link
Member

julien-c commented Jul 29, 2024

and @mishig25 you can probably pause the previous Space then?

Copy link
Collaborator

@mishig25 mishig25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once screenshots are added.

Should I go ahead and pause https://huggingface.co/spaces/scanned-tokens/exposed-tokens ?

@julien-c
Copy link
Member

@mishig25 yes

@McPatate McPatate force-pushed the feat/secret_detection_update branch from e0cc855 to 7de9982 Compare August 30, 2024 16:28
@McPatate McPatate force-pushed the feat/secret_detection_update branch from 7de9982 to 596c01b Compare August 30, 2024 16:32
@McPatate McPatate merged commit 5249006 into main Aug 30, 2024
2 checks passed
@McPatate McPatate deleted the feat/secret_detection_update branch August 30, 2024 16:36
@McPatate
Copy link
Member Author

I went ahead and merged to have an up to date version of the docs page for the email link as people have started receiving them. Lmk if something isn't right I'll re-open a PR to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants