fix: use simple_error instead of PyException #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experienced this tools hanging without any error like #37 #30 and it happened more frequently in poor Internet situation.
It appears that the
PyException
type is experiencing performance issues during string conversion, which may lead to blocking of Tokio asynchronous tasks.This blocking can prevent the timely dropping of semaphores, causing the semaphore pool associated with max_files to be quickly exhausted, ultimately leading to a deadlock in the entire program.
This PR addresses the issue by changing the return type of the download_chunk function to simple_error to circumvent this problem.