Add means of disabling native-tls #37
Closed
+4
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
Thank you for making the Hugging Face hub, it's super convenient.
This PR adds a means of disabling the
native-tls
dependency, because we're usingrust_tls
and really don't want the native one.It works by adding a new default feature
native-tls
that adds the existingnative-tls
optional dependencies (both for ureq and as a direct dependency). So by default this PR doesn't change anything.However, it is now possible to remove the
native-tls
dependencies by adding thehf-hub
without its default features, and with theonline
feature enabled.I checked that the resulting cargo tree doesn't have
native-tls
at all in this configuration, whilenative-tls
remains when the default features are enabled.Thank you for reading 🙂