Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add means of disabling native-tls #37

Closed
wants to merge 1 commit into from

Conversation

dureuill
Copy link

Hello 👋

Thank you for making the Hugging Face hub, it's super convenient.

This PR adds a means of disabling the native-tls dependency, because we're using rust_tls and really don't want the native one.

It works by adding a new default feature native-tls that adds the existing native-tls optional dependencies (both for ureq and as a direct dependency). So by default this PR doesn't change anything.

However, it is now possible to remove the native-tls dependencies by adding the hf-hub without its default features, and with the online feature enabled.

I checked that the resulting cargo tree doesn't have native-tls at all in this configuration, while native-tls remains when the default features are enabled.

Thank you for reading 🙂

@McPatate
Copy link
Member

McPatate commented Apr 2, 2024

Closing in favor of #53

@McPatate McPatate closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants