Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved for empty datafiles #7314

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Resolved for empty datafiles #7314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab76a8b
Resolved for empty datafiles
Dec 9, 2024
168c91d
Merge branch 'main' into 6152
sahillihas Dec 14, 2024
63194cf
Merge branch 'main' into 6152
sahillihas Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/datasets/load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1871,6 +1871,7 @@ def load_dataset_builder(
if (
path in _PACKAGED_DATASETS_MODULES
and data_files is None
and not data_files
and dataset_module.builder_configs_parameters.builder_configs[0].data_files is None
):
error_msg = f"Please specify the data files or data directory to load for the {path} dataset builder."
Expand Down
2 changes: 1 addition & 1 deletion src/datasets/packaged_modules/folder_based_builder/folder_based_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def _info(self):
return datasets.DatasetInfo(features=self.config.features)

def _split_generators(self, dl_manager):
if not self.config.data_files:
if self.config.data_files is not None and not self.config.data_files:
raise ValueError(f"At least one data file must be specified, but got data_files={self.config.data_files}")
dl_manager.download_config.extract_on_the_fly = True
# Do an early pass if:
Expand Down