Do not consume unnecessary memory during sharding #7136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to create a temporary list of a potentially very large step/world size.
janEbert
force-pushed
the
fix-shard-oom
branch
from
e90b8a7 to
afeaa9a
Compare
janEbert
added a commit
to TrustLLMeu/trustllm-envs
that referenced
this pull request
Sep 4, 2024
Patching can be removed once LLM Foundry uses a `datasets` version that has huggingface/datasets#7136 integrated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sharding
IterableDatasets, a temporary list is created that is then indexed. There is no need to create a temporary list of a potentially very large step/world size, with standardislicefunctionality, so we avoid it.Runs successfully.