[Assistants settings] Update reported data backend
#871
Conversation
mishig25
force-pushed
the
update_report_query
branch
from
256ee00 to
7bd937b
Compare
mishig25
changed the title
reported data backend
| @@ -21,6 +22,30 @@ async function assistantOnlyIfAuthor(locals: App.Locals, assistantId?: string) { | |||
| return assistant; | |||
| } | |||
|
|
|||
| export async function load({ parent, params, locals }) { | |||
| const data = await parent(); | |||
There was a problem hiding this comment.
Note that this triggers the root's +layout.server.ts's load.
So each time we switch assistant, this will trigger a load of all assistants
IMO we can keep the redirect in page.ts - that way the load isn't triggered - since the frontend will be able to execute it.
TLDR:
- Keep
page.tsas is - remove the redirect /
parent()call here - The rest of the PR is great!
There was a problem hiding this comment.
handled in 1d5994f
|
How does it work when you have both a server load function and a universal load function for the same |
// `data` comes from the server load function
export async function load({ parent, data }) {
const res = await parent();
// checks
...
return data;
}Something like that |
Only check if current assistant that is being viewed was
reported.Previously, we were checking
reportedstatus on all the assistants of a user. However, thisreportedstatus is only useful for the assistant that is currently being viewed