Add speech recognition to chat interface #1541
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarrazin
reviewed
Oct 28, 2024
There was a problem hiding this comment.
Love the idea of this PR, thanks for the contrib! I tried it a bit and I think it could be a great addition.
Couple points:
- We should check if the browser supports webgpu, I tried it on firefox and it failed silently initially because it's not supported by default. If that's the case maybe we should hide the icon?
- Would be nice to have some kind of download indicator for the transcription model, maybe a small download bar below the mic icon when you press it? Otherwise you get no feedback until it's done.
- We already have a few loading animations, do you think we could be using these instead? (
src/lib/components/icons/IconLoading.svelteandimport EosIconsLoading from "~icons/eos-icons/loading";) - Sometimes I stop recording and record again and it seems to transcribe the previous recording only. Overall this is super cool but maybe the audio chunks should be cleared when you start a new recording ?
nsarrazin
reviewed
Oct 28, 2024
| } | ||
|
|
||
| onMount(() => { | ||
| const microphoneButton = document.querySelector("#microphone-button"); |
There was a problem hiding this comment.
With svelte, it's usually best to bind to the element instead of using a query selector if possible using bind:this https://svelte.dev/docs/svelte/bind#bind:this
You should also just be able to use on:click directly no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.