Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to send user message as part of request body in assistant … #1322

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ethayu
Copy link

@ethayu ethayu commented Jul 1, 2024

Add support for to send user message/query within assistant invocations, as referenced in #1302.

@ethayu
Copy link
Author

ethayu commented Jul 1, 2024

@nsarrazin please let me know your thoughts

Copy link
Collaborator

@nsarrazin nsarrazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for the contrib!

Do you think we could instead do something like {{url|post=https://example.com}} so that we can keep the old functionality as well ?

@ethayu
Copy link
Author

ethayu commented Aug 25, 2024

@nsarrazin about keeping the old functionality:
my changes don't remove any existing functionality - it just makes it such that if a new env variable ENABLE_ASSISTANTS_POST is set to true, any call to {{url=https://example.com}} will be a POST request instead of a GET request, with the user prompt sent as the message body.

could you approve the workflow again? I had to resolve some merge conflicts.

@nsarrazin
Copy link
Collaborator

it just makes it such that if a new env variable ENABLE_ASSISTANTS_POST is set to true, any call to {{url=https://example.com}} will be a POST request instead of a GET

Yep, my point was that if we use a different keyword like url|post instead of setting it with an env variable then we can support both GET and POST in the same config 😄

@ethayu
Copy link
Author

ethayu commented Aug 26, 2024

Yes, that actually makes more sense. I’ll do that.

@nsarrazin
Copy link
Collaborator

Hi @ethayu do you still want to take a look at this? Just curious no pressure 😄

@ethayu
Copy link
Author

ethayu commented Oct 20, 2024

@nsarrazin sorry, I've been a little swamped with school recently! I'll get to it around thanksgiving break, if nobody else has taken care of it by then

@ethayu
Copy link
Author

ethayu commented Dec 23, 2024

@nsarrazin done! please take a look 😄

@ethayu
Copy link
Author

ethayu commented Dec 23, 2024

@nsarrazin lint issue fixed 😂

@ethayu
Copy link
Author

ethayu commented Dec 24, 2024

@nsarrazin Could you kick off the checks please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants