Improve candle_core::Error
to make it more ergonomic
#2467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our Error type is already useful but could benefit from some of the QoL features which the anyhow crate has.
This PR adds the following:
Error::msg
more in line withanyhow::Error::msg
. Although the type bound changes, this is not a breaking change becausestd::error::Error: Display
already.Context
trait. Inspired by anyhow's Context trait which allows for.with_context
and.context
on Options and Results. Very useful!