-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add image-preferences blogpost #2520
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvsrepo
reviewed
Dec 9, 2024
dvsrepo
reviewed
Dec 9, 2024
dvsrepo
reviewed
Dec 9, 2024
dvsrepo
reviewed
Dec 9, 2024
dvsrepo
reviewed
Dec 9, 2024
dvsrepo
reviewed
Dec 9, 2024
dvsrepo
reviewed
Dec 9, 2024
dvsrepo
reviewed
Dec 9, 2024
sdiazlor
reviewed
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- What's the final intention? Community or dataset release? Depending on that, I'd shorten the title with a more straightforward one
- I don't remember exactly where, but I recall some conversations mentioning that adding a short tldr section right at the beginning was useful for users to know what they can expect
- Mention to https://huggingface.co/data-is-better-together-contributor?
sayakpaul
reviewed
Dec 9, 2024
sayakpaul
reviewed
Dec 9, 2024
sayakpaul
reviewed
Dec 9, 2024
sayakpaul
reviewed
Dec 9, 2024
sayakpaul
reviewed
Dec 9, 2024
sayakpaul
reviewed
Dec 9, 2024
sayakpaul
reviewed
Dec 9, 2024
sayakpaul
reviewed
Dec 9, 2024
sayakpaul
reviewed
Dec 9, 2024
sayakpaul
reviewed
Dec 9, 2024
sayakpaul
reviewed
Dec 9, 2024
sayakpaul
reviewed
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Left a couple of comments.
update images with tinypng version
add example tables
add thumbnail
dvsrepo
approved these changes
Dec 9, 2024
Vaibhavs10
approved these changes
Dec 9, 2024
@Vaibhavs10 thanks, can you also merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Congratulations! You've made it this far! Once merged, the article will appear at https://huggingface.co/blog. Official articles
require additional reviews. Alternatively, you can write a community article following the process here.
Preparing the Article
You're not quite done yet, though. Please make sure to follow this process (as documented here):
md
file. You can also specifyguest
ororg
for the authors.Here is an example of a complete PR: #2382
Getting a Review
Please make sure to get a review from someone on your team or a co-author.
Once this is done and once all the steps above are completed, you should be able to merge.
There is no need for additional reviews if you and your co-authors are happy and meet all of the above.
Feel free to add @pcuenca as a reviewer if you want a final check. Keep in mind he'll be biased toward light reviews
(e.g., check for proper metadata) rather than content reviews unless explicitly asked.