Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the Llama3.1 prompt template #2258

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wizzard0
Copy link

The llama 3.1 tool calling template says "orginal user question" instead of the "original user question".

Unless it's the actual prompt pattern the model is trained with, this should affect the tool use performance; and I see this typo spreading to other tutorials and tools using Llama 3.1

The llama 3.1 tool calling template says "orginal user question" instead of the "original user question". 

Unless it's the actual prompt pattern the model is trained with, this should affect the tool use performance; and I see this typo spreading to other tutorials and tools using Llama 3.1
@pcuenca
Copy link
Member

pcuenca commented Jul 29, 2024

Hi @wizzard0! Actually, the typo is also present in the official documentation (see Step 3 in the JSON-based tool calling section). I doubt that the system prompt has to be supplied verbatim like that and I'd prefer to have the typo fixed, but I haven't really tested it comprehensively. Have you observed differences one way or another?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants