Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest bnb no longer has optim_args attribute on optimizer #3311

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

winglian
Copy link
Contributor

@winglian winglian commented Dec 23, 2024

What does this PR do?

with latest bitsandbytes:

[rank1]:   File "/root/miniconda3/envs/py3.11/lib/python3.11/site-packages/accelerate/utils/deepspeed.py", line 53, in map_pytorch_optim_to_deepspeed                                                                                                        
[rank1]:     is_adaw = isinstance(optimizer, (bnb_opt.AdamW, bnb_opt.AdamW32bit)) and optimizer.optim_bits == 32                                                                                                                                             
[rank1]:                                                                              ^^^^^^^^^^^^^^^^^^^^                                                                                                                                                   
[rank1]: AttributeError: 'AdamW' object has no attribute 'optim_bits'                                                                                                                                                                                        

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@muellerzr

@winglian
Copy link
Contributor Author

we might have to combine this with #3305 @bursteratom. I think 3305 isn't backwards compatible with older versions of bnb, but it also checks the lion optimizer case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant