Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSDP] Make env var and dataclass flag consistent for cpu_ram_efficient_loading #3307

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SumanthRH
Copy link
Contributor

@SumanthRH SumanthRH commented Dec 19, 2024

What does this PR do?

Makes environment variable and dataclass consistent for cpu_ram_efficient_loading. Currently, there's an inconsistency when the FSDP plugin is initialized in a standalone fashion: the cpu_ram_efficient_loading flag can be set to True but if the user doesn't use accelerate launch , then the environment variable FSDP_CPU_RAM_EFFICIENT_LOADING would not be set. This environment variable is actually used by transformers to initialize parameters efficiently in the process group (See: #2100 (comment) for details on how this happens)

I can see a previous PR #2998 that tried to make all env vars optional, but looks like this was left.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

cc @muellerzr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant