[FSDP] Make env var and dataclass flag consistent for cpu_ram_efficient_loading
#3307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes environment variable and dataclass consistent for
cpu_ram_efficient_loading
. Currently, there's an inconsistency when the FSDP plugin is initialized in a standalone fashion: thecpu_ram_efficient_loading
flag can be set toTrue
but if the user doesn't useaccelerate launch
, then the environment variableFSDP_CPU_RAM_EFFICIENT_LOADING
would not be set. This environment variable is actually used by transformers to initialize parameters efficiently in the process group (See: #2100 (comment) for details on how this happens)I can see a previous PR #2998 that tried to make all env vars optional, but looks like this was left.
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
cc @muellerzr