Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration CI #2047

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Fix integration CI #2047

merged 2 commits into from
Oct 12, 2023

Conversation

muellerzr
Copy link
Collaborator

What does this PR do?

Fixes issue finding the last latest release from github for transformers, need a better way to search for it in case what happened last time happens again, where a release was made but not a release branch. This method will grab all actual existing tags and search for the latest one made/release.

Fixes # (issue)

Failing pypi integration tests on main. See here for an example completed run

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@BenjaminBossan

@muellerzr muellerzr changed the title Fix deepspeed install Fix integration CI Oct 11, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 11, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue. It's not quite clear to me how the previous way of checking out the latest tag worked, but the new one looks good to me.

@muellerzr muellerzr merged commit 1dfb6e9 into main Oct 12, 2023
32 of 34 checks passed
@muellerzr muellerzr deleted the fix-deepspeed-install branch October 12, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants