/analyze-hashed endpoint using cached pcontext
#1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaneenders
changed the title
/analyze-hashed endpoint using cached pcontext
pavpanchekha
requested changes
Nov 19, 2024
Comment on lines
+158
to
+171
| (match type | ||
| ['errors-hash | ||
| (when (hash-has-key? completed-work pcontext) | ||
| (set! command | ||
| (herbie-command 'errors | ||
| test | ||
| seed | ||
| (json->pcontext (hash-ref (hash-ref completed-work pcontext) | ||
| 'points) | ||
| (test-context test)) | ||
| profile? | ||
| timeline-disabled?)) | ||
| (set! action (server-action 'herbie-command command)))] | ||
| [_ empty]) |
There was a problem hiding this comment.
This is a crazy design. Why is this a new type of job? Why not handle this when parsing the pcontext from JSON? Why do we even need a separate endpoint?
Separately, where's the error handling? We should gracefully inform Odyssey if the hash can't be found, say if the server got restarted while Odyssey was working. And Odyssey should ideally know how to handle this correctly, not sure what that would be (maybe re-submit without caching?).
zaneenders
force-pushed
the
zane-server-translate
branch
from
1979a2f to
e34c789
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a
/analyze-hashedendpoint for Odyssey to avoid sending the pcontext back and forth. This should fix #1048