Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use serveDirectoryFileServer #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use serveDirectoryFileServer #37

wants to merge 1 commit into from

Conversation

k-bx
Copy link

@k-bx k-bx commented Mar 18, 2019

Failed to build previously with:

examples/counter.hs:72:19: warning: [-Wdeprecations]
    In the use of ‘serveDirectory’
    (imported from Servant, but defined in Servant.Server.StaticFiles):
    Deprecated: "Use serveDirectoryFileServer instead"
   |
72 |              :<|> serveDirectory www -- serve static files
   |                   ^^^^^^^^^^^^^^

@k-bx
Use serveDirectoryFileServer
6e307a5 
Failed to build previously
@phadej
Copy link
Contributor

phadej commented Mar 18, 2019 •
edited
Loading

It did not fail. Warning is not a failure.

EDIT It really matters, as I thought there's actually a broken release. But there aren't.

@k-bx
Copy link
Author

k-bx commented Mar 18, 2019

@phadej sorry! My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-bx @phadej