Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gw-create-coupon.php: Fixed WooCommerce coupon description not set issue. #972

Merged

Conversation

malayladu
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2786023627/75268#thread-8459491127

Summary

This PR fix the coupon description not set in WooCommerce. Instead of post_content, we need to use post_excerpt to set the coupon description in WooCommerce.

@malayladu malayladu self-assigned this Dec 19, 2024
@malayladu malayladu changed the title Set WooCommerce coupon description gw-create-coupon.php: Fixed WooCommerce coupon description not set issue. Dec 19, 2024
@saifsultanc
Copy link
Contributor

@malayladu Great work! You will need to fixup the commit messages, please see our Notion about this here: https://www.notion.so/d5bee101d9674dfc98d7ec007867de2b#99a324137159438bb98cd8d562f61374

Just follow the exact format as you have for the PR title. https://www.loom.com/share/d13f4fa759b04b32954c011b0941819f

@malayladu malayladu force-pushed the malay/fix/75268-set-woocommerce-coupon-description branch 2 times, most recently from 5635132 to 0fc8b8a Compare December 19, 2024 17:00
@malayladu
Copy link
Contributor Author

@saifsultanc Thanks for sharing.

Yaay...it fixed now. All checks passed!!

Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Can you make one last tweak to the snippet, incrementing the version from 1.2.2 to 1.2.3? This is a good habit to get into 😄

@malayladu malayladu force-pushed the malay/fix/75268-set-woocommerce-coupon-description branch from 0fc8b8a to d99a39f Compare December 20, 2024 02:41
@malayladu
Copy link
Contributor Author

@claygriffiths Bumped version to 1.2.3. It's ready to merge!

Copy link
Contributor

@saifsultanc saifsultanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All you need to do is S&M, just remove the PR number from the message. So the following-

gw-create-coupon.php: Fixed WooCommerce coupon description not set issue.

Once done, send an update to the customer.

@malayladu malayladu merged commit a6e4263 into master Dec 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants