Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move one mimirpb custom type to separate package #10316

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

move one mimirpb custom type to separate package #10316

wants to merge 1 commit into from

Conversation

francoposa
Copy link
Member

What this PR does

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

pracucci
pracucci reviewed Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing the context of this change. However, instead of calling the package mimirpb_custom have you considered naming the package based on the actual content, e.g. labelspb?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pracucci pracucci pracucci left review comments

@wilfriedroset wilfriedroset Awaiting requested review from wilfriedroset wilfriedroset will be requested when the pull request is marked ready for review wilfriedroset is a code owner

@vaxvms vaxvms Awaiting requested review from vaxvms vaxvms will be requested when the pull request is marked ready for review vaxvms is a code owner

@bubu11e bubu11e Awaiting requested review from bubu11e bubu11e will be requested when the pull request is marked ready for review bubu11e is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francoposa @pracucci