Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to OTel v0.116.0 #1484

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade to OTel v0.116.0 #1484

wants to merge 1 commit into from

Conversation

ptodev
Copy link

@ptodev ptodev commented Dec 30, 2024

I believe this is required in order to update Alloy to OTel v0.116.0 as well.

I was not able to run make on my Mac due to this error:

Error: exec: "llvm-strip": executable file not found in $PATH

I suppose the build only works on Linux? I hope the PR CI will let me know if anything else such as third_party_licenses.csv needs updating.

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.98%. Comparing base (0cdf322) to head (7083b65).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1484      +/-   ##
==========================================
- Coverage   81.34%   76.98%   -4.36%     
==========================================
  Files         149      149              
  Lines       15264    15268       +4     
==========================================
- Hits        12416    11754     -662     
- Misses       2244     2901     +657     
- Partials      604      613       +9     
Flag Coverage Δ
integration-test 59.79% <100.00%> (+0.02%) ⬆️
k8s-integration-test ?
oats-test 34.01% <100.00%> (-0.03%) ⬇️
unittests 52.08% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptodev
Copy link
Author

ptodev commented Dec 30, 2024

I tried to run just make update-licenses, but it failed for some unknown reason. Maybe it's easier if someone from the Beyla team runs it on the PR please?

@ptodev
Copy link
Author

ptodev commented Jan 1, 2025

@grafana/beyla Is there any chance that you could remove this go mod replace from your go.mod file please:

replace go.opentelemetry.io/otel/metric => github.com/grafana/opentelemetry-go/metric v1.28.0-grafana.3

It is causing an issue with the Alloy build:

/go/pkg/mod/github.com/grafana/[email protected]/pkg/export/otel/metrics.go:982:68: "go.opentelemetry.io/otel/metric".Float64Histogram does not satisfy removableMetric[float64] (missing method Remove)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant