Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add TCX support #1478

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

WIP: Add TCX support #1478

wants to merge 2 commits into from

Conversation

rafaelroquetto
Copy link
Contributor

@rafaelroquetto rafaelroquetto commented Dec 20, 2024

TODO

  • add the config switches to let the user pick among tc, tcx or auto
  • add a function that detects support for tcx in the host kernel
    • if the support is there and the user has chosen auto, we use it, otherwise we fallback to tc
    • if the support is not there and the user has chosen tcx, we error out and bail
  • cleanup Register() method from the netolly tracer
  • tests
  • documentation

This is a variant of the existing interface filter present in the
'agent' package.
@rafaelroquetto rafaelroquetto added the do-not-merge WIP or something that musn't be merged label Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 49.66667% with 302 lines in your changes missing coverage. Please review.

Project coverage is 72.20%. Comparing base (1192264) to head (5ddde6f).

Files with missing lines Patch % Lines
pkg/internal/ebpf/tcmanager/tcxmanager.go 0.00% 163 Missing ⚠️
pkg/internal/ebpf/tcmanager/netlinkmanager.go 68.49% 66 Missing and 20 partials ⚠️
pkg/internal/ebpf/tcmanager/filter.go 47.54% 24 Missing and 8 partials ⚠️
pkg/internal/netolly/agent/agent.go 70.45% 12 Missing and 1 partial ⚠️
pkg/internal/ebpf/httptracer/httptracer.go 77.77% 2 Missing and 2 partials ⚠️
pkg/internal/ebpf/tctracer/tctracer.go 82.35% 2 Missing and 1 partial ⚠️
pkg/internal/netolly/ebpf/tracer.go 92.30% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1192264) and HEAD (5ddde6f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1192264) HEAD (5ddde6f)
unittests 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1478      +/-   ##
==========================================
- Coverage   81.45%   72.20%   -9.26%     
==========================================
  Files         149      151       +2     
  Lines       15253    15516     +263     
==========================================
- Hits        12425    11204    -1221     
- Misses       2228     3579    +1351     
- Partials      600      733     +133     
Flag Coverage Δ
integration-test 58.86% <48.16%> (-0.92%) ⬇️
k8s-integration-test 60.37% <48.66%> (+0.50%) ⬆️
oats-test 33.38% <0.00%> (-0.64%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge WIP or something that musn't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant