CMake: Support for using build_profile.json #1670
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enetheru
force-pushed
the
build_profile
branch
2 times, most recently
from
35ca242 to
fddcb8d
Compare
enetheru
force-pushed
the
build_profile
branch
4 times, most recently
from
5bcc2c5 to
fb65d7b
Compare
Simplify <platform>_generate cmake function signature, as TARGET_ALIAS and TARGET_NAME are still in scope and do not need to be passed. Add USE_FOLDERS, and FOLDER properties to group targets in VS and XCode Guard test target with GODOT_ENABLE_TESTING Generate all three variants in the form godot-cpp.test.<target> to remove the -DTEST_TARGET option clutter. Update the docs/cmake.rst with information about the testing target Update the Github CI
Python: - Redirect stdout for get_file_list to prevent stdout pollution CMake: - add GODOT_BUILD_PROFILE cache option - Split file list generation into its own function - add status and debug messages Python Snippets in CMake: - re-format for better readability Build Profile: - Add missing VisualInstance3D class to build_profile.json
enetheru
force-pushed
the
build_profile
branch
from
fb65d7b to
92696e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to get Link-Time Optimisation working to close out one of the Issues or PR's and was running into binary limits for MSVC, which was also failing in scons.
I could alleviate that problem in SCons using
build_profile=build_profile.jsonin the test project to reduce the binary size enough to get it working. However that option was not yet implemented in the CMake project.This PR is to bring the CMake situation upto scratch with regards to using build_profiles
The change list is a little messy atm as it is built upon the name_clash changes, when that is merged I will re-base and it will look a lot cleaner.
Changes
CMake:
Build Profile:
Python: