fix: task level vars are not ignored in requires #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 15, 2024
pd93
reviewed
Dec 29, 2024
andreynering
approved these changes
Dec 30, 2024
|
FYI: Looks like there was a previous PR that addresses this issue: #1769 |
|
@vmaerten No problem. It's fine to merge this one, but we'll need to close that PR. Good reminder that when adding a line with |
Co-authored-by: Andrey Nering <[email protected]>
vmaerten
force-pushed
the
fix/require-vars
branch
from
d599cbd to
4f56e1d
Compare
vmaerten
added a commit
that referenced
this pull request
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes :
AFAIK, there is no reason to pass nil to vars in
compiledTaskAm I missing something here ?