feat: Make CHECKSUM and TIMESTAMP vars available in cmds commands #1872
+62
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasr22
changed the title
vmaerten
reviewed
Dec 30, 2024
| @@ -228,7 +181,7 @@ func (e *Executor) compiledTask(call *ast.Call, evaluateShVars bool) (*ast.Task, | |||
| } | |||
| } | |||
|
|
|||
| if len(origTask.Status) > 0 { | |||
There was a problem hiding this comment.
I'm not a big fan of those two nested if statements.
TIMESTAMP and CHECKSUM should only be available if there are sources defined. I'd replace len(origTask.Status) > 0 with len(origTask.Source) > 0 and move it above cmds.
There was a problem hiding this comment.
True, good idea. I changed it like you said but now it also has the effect that .TIMESTAMP and .CHECKSUM are available in preconditions and deps. Do you want to keep it like that?
niklasr22
force-pushed
the
cmds-with-checksum-and-timestamp-vars
branch
2 times, most recently
from
104542a to
370d528
Compare
|
Lint job is failing. a |
niklasr22
force-pushed
the
cmds-with-checksum-and-timestamp-vars
branch
from
370d528 to
856aa66
Compare
niklasr22
force-pushed
the
cmds-with-checksum-and-timestamp-vars
branch
from
856aa66 to
7d9a093
Compare
vmaerten
approved these changes
Dec 31, 2024
vmaerten
added a commit
that referenced
this pull request
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this is my attempt to fix #1735.