Reimplement duration rounding #301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is part of a set of multiple pull requests looking to overhaul the calculation functions.)
This pull request reimplements duration rounding.
roundToSingleUnitnow rebalances the incoming duration byapplying theDurationto the reference date and recomputes a new balanced duration withelapsedTime. A new functionroundBalancedToSingleUnitis added which does the actual rounding using a generalized routine across all units.This implementation does not account for the perceptual difference in the units of the two dates but rather only considers the duration itself. A new relative time implementation that considers the perceptual difference is in pull request #300.
Certain tests were temporarily modified to accomodate this pull request's isolated changes and will need to be changed again as other parts of the pull request set are completely integrated.