Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the chance of blinking on annotation layers. #871

Merged
merged 1 commit into from
May 31, 2022

Conversation

manthey
Copy link
Member

@manthey manthey commented May 31, 2022

When the base image is panned, sometimes an update occurs before the reset features are updated. This forces the update sooner.

@manthey manthey changed the title Reduce the change of blinking on annotation layers. Reduce the chance of blinking on annotation layers. May 31, 2022
When the base image is panned, sometimes an update occurs before the
reset features are updated.  This forces the update sooner.
@manthey manthey force-pushed the reduce-annotation-blink branch from ee89055 to aca983f Compare May 31, 2022 16:29
@manthey manthey merged commit d20d7d8 into master May 31, 2022
@manthey manthey deleted the reduce-annotation-blink branch May 31, 2022 17:06
@ds2268
Copy link

ds2268 commented Jun 6, 2022

@manthey I checked, as described in DigitalSlideArchive/digital_slide_archive#214 and it does not solve the issue.

I also checked dsa_girder docker container and the large_image contains the latest changes, so I should have the patches included. I suggest that we have a call where I demo to you the bottlenecks and blinking/refreshing stuff.

@ds2268
Copy link

ds2268 commented Jun 8, 2022

Ah, I have now cleaned all the old docker images manually and redeployed the DSA and now the bug seems to be fixed. It's really much more responsive! Next week we will start real-world usage again on a larger scale and will report back if there are any bottlenecks left. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants