Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mouse events to overlay layers #794

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Add mouse events to overlay layers #794

merged 2 commits into from
Mar 15, 2022

Conversation

naglepuff
Copy link
Collaborator

Similar to how annotation feature elements, hook up overlay elements to mouse events.

@naglepuff naglepuff requested a review from manthey March 10, 2022 18:59
@naglepuff naglepuff mentioned this pull request Mar 10, 2022
Merged
1 task
@naglepuff
Add test
804517b 
Test that overlay mouse events are fired when overlay and overlay layer
are provided.
@naglepuff
Copy link
Collaborator Author

@manthey I added a test. Could you take a look at it when you get a chance?

@naglepuff naglepuff requested a review from manthey March 15, 2022 14:35
manthey
manthey approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@manthey manthey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test.

@naglepuff naglepuff merged commit 36614ef into master Mar 15, 2022
@naglepuff naglepuff deleted the overlay-mouse-events branch March 15, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manthey manthey manthey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naglepuff @manthey