Harden detecting file-not-found. #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manthey
commented
Dec 13, 2021
| return True | ||
| if ds.GetDriver().ShortName in {'NITF', 'netCDF'}: | ||
| return True | ||
| if ds: |
There was a problem hiding this comment.
In the conda installation, GDAL returns a dataset handle even when the file isn't found. In the pip installation, it raises an exception. Both have gdal 3.4.0.
There was a problem hiding this comment.
That is very odd... I wonder what exactly causes this difference? Perhaps a build flag? This would be good to raise in the GDAL conda-forge feedstock
This handles some difference in the conda and pip installations of gdal.
manthey
force-pushed
the
harden-file-not-found
branch
from
92fba3c to
e9e42c9
Compare
banesullivan
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
I can confirm that this is now raising a TileSourceFileNotFoundError error for my, conda-based, GDAL installation:
>>> import large_image
>>> large_image.open('foo.tif')
Could not find Java JRE compatible with x86_64 architecture
Using python for large_image caching
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/bane/Software/kw/large_image/large_image/tilesource/__init__.py", line 143, in open
return getTileSource(*args, **kwargs)
File "/Users/bane/Software/kw/large_image/large_image/tilesource/__init__.py", line 131, in getTileSource
return getTileSourceFromDict(AvailableTileSources, *args, **kwargs)
File "/Users/bane/Software/kw/large_image/large_image/tilesource/__init__.py", line 118, in getTileSourceFromDict
raise TileSourceFileNotFoundError(pathOrUri)
large_image.exceptions.TileSourceFileNotFoundError: [Errno 2] foo.tif>>> large_image.open('/vsicurl?url=https%3A%2F%2Ffoo.com%2Fbar.png&use_head=no&list_dir=no')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/bane/Software/kw/large_image/large_image/tilesource/__init__.py", line 143, in open
return getTileSource(*args, **kwargs)
File "/Users/bane/Software/kw/large_image/large_image/tilesource/__init__.py", line 131, in getTileSource
return getTileSourceFromDict(AvailableTileSources, *args, **kwargs)
File "/Users/bane/Software/kw/large_image/large_image/tilesource/__init__.py", line 118, in getTileSourceFromDict
raise TileSourceFileNotFoundError(pathOrUri)
large_image.exceptions.TileSourceFileNotFoundError: [Errno 2] /vsicurl?url=https%3A%2F%2Ffoo.com%2Fbar.png&use_head=no&list_dir=no
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles some difference in the conda and pip installations of gdal.
Closes #656.