Improve tile source locking. #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, if two different tile sources using the same cache were being opened simultaneously, they would be opened sequentially due to the locking semantics. This also prevented opening the same source twice. Now, when a tile source is not in cache, a separate per-key lock is created for opening that source. This prevents the same source from being opened twice but allows different sources to be opened concurrently.
manthey
force-pushed
the
better-source-locking
branch
from
7d6370e to
18576d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if two different tile sources using the same cache were being opened simultaneously, they would be opened sequentially due to the locking semantics. This also prevented opening the same source twice.
Now, when a tile source is not in cache, a separate per-key lock is created for opening that source. This prevents the same source from being opened twice but allows different sources to be opened concurrently.